Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_sesv2_email_identity_policy: new resource #35486

Merged
merged 4 commits into from
Jan 29, 2024
Merged

r/aws_sesv2_email_identity_policy: new resource #35486

merged 4 commits into from
Jan 29, 2024

Conversation

kamilturek
Copy link
Collaborator

@kamilturek kamilturek commented Jan 25, 2024 •
edited
Loading

Description

This PR introduces a new aws_sesv2_email_identity_policy resource.

Relations

Relates #26796.

References

https://docs.aws.amazon.com/ses/latest/APIReference-V2/API_CreateEmailIdentityPolicy.html
https://docs.aws.amazon.com/ses/latest/APIReference-V2/API_DeleteEmailIdentityPolicy.html
https://docs.aws.amazon.com/ses/latest/APIReference-V2/API_GetEmailIdentityPolicies.html
https://docs.aws.amazon.com/ses/latest/APIReference-V2/API_UpdateEmailIdentityPolicy.html

Output from Acceptance Testing

% make testacc TESTARGS="-run=TestAccSESV2EmailIdentityPolicy_" PKG=sesv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 20  -run=TestAccSESV2EmailIdentityPolicy_ -timeout 360m
=== RUN   TestAccSESV2EmailIdentityPolicy_basic
=== PAUSE TestAccSESV2EmailIdentityPolicy_basic
=== RUN   TestAccSESV2EmailIdentityPolicy_disappears
=== PAUSE TestAccSESV2EmailIdentityPolicy_disappears
=== CONT  TestAccSESV2EmailIdentityPolicy_basic
=== CONT  TestAccSESV2EmailIdentityPolicy_disappears
--- PASS: TestAccSESV2EmailIdentityPolicy_disappears (16.06s)
--- PASS: TestAccSESV2EmailIdentityPolicy_basic (18.41s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      24.002s

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. service/sesv2 Issues and PRs that pertain to the sesv2 service. generators Relates to code generators. labels Jan 25, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Jan 25, 2024
@kamilturek kamilturek mentioned this pull request Jan 25, 2024
Closed
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 25, 2024
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/L Managed by automation to categorize the size of a PR. labels Jan 27, 2024
@kamilturek kamilturek marked this pull request as ready for review January 27, 2024 15:41
ewbankkit
ewbankkit approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSESV2EmailIdentityPolicy_' PKG=sesv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 20  -run=TestAccSESV2EmailIdentityPolicy_ -timeout 360m
=== RUN   TestAccSESV2EmailIdentityPolicy_basic
=== PAUSE TestAccSESV2EmailIdentityPolicy_basic
=== RUN   TestAccSESV2EmailIdentityPolicy_disappears
=== PAUSE TestAccSESV2EmailIdentityPolicy_disappears
=== CONT  TestAccSESV2EmailIdentityPolicy_basic
=== CONT  TestAccSESV2EmailIdentityPolicy_disappears
--- PASS: TestAccSESV2EmailIdentityPolicy_disappears (19.62s)
--- PASS: TestAccSESV2EmailIdentityPolicy_basic (22.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sesv2	32.166s

@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 6d700ad into hashicorp:main Jan 29, 2024
52 checks passed
@github-actions github-actions bot added this to the v5.35.0 milestone Jan 29, 2024
@kamilturek kamilturek deleted the f-aws-sesv2-email-identity-policy branch January 30, 2024 20:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024

This functionality has been released in v5.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. new-resource Introduces a new resource. service/sesv2 Issues and PRs that pertain to the sesv2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.35.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kamilturek @ewbankkit @justinretzolk